nrknithin commented on code in PR #2244:
URL:
https://github.com/apache/incubator-kie-examples/pull/2244#discussion_r3900701711
##########
kogito-quarkus-examples/pom.xml:
##########
@@ -219,27 +337,257 @@
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-surefire-plugin</artifactId>
+ <artifactId>maven-resources-plugin</artifactId>
+ <version>2.5</version>
+ <executions>
+ <execution>
+ <id>add-it-resources</id>
+ <phase>pre-integration-test</phase>
+ <goals>
+ <goal>copy-resources</goal>
+ </goals>
+ <configuration>
+
<outputDirectory>${project.build.directory}/test-run/META-INF</outputDirectory>
+ <resources>
+ <resource>
+ <directory>target/classes/META-INF</directory>
+ </resource>
+ </resources>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
<version>${version.surefire.plugin}</version>
<configuration>
+ <forkCount>${surefire.forkCount}</forkCount>
+ <reuseForks>true</reuseForks>
+ <includes>
+ <include>${failsafe.include}</include>
+ </includes>
+ <excludes>
+ <exclude>${failsafe.exclude}</exclude>
+ </excludes>
<systemPropertyVariables>
<java.util.logging.manager>org.jboss.logmanager.LogManager</java.util.logging.manager>
+
<quarkus.http.test-port>${tests.quarkus.http.port}</quarkus.http.test-port>
+ <tests.category>${tests.category}</tests.category>
+
<enable.resource.infinispan>${enable.resource.infinispan}</enable.resource.infinispan>
+
<enable.resource.kafka>${enable.resource.kafka}</enable.resource.kafka>
+
<enable.resource.postgresql>${enable.resource.postgresql}</enable.resource.postgresql>
+
<enable.resource.mongodb>${enable.resource.mongodb}</enable.resource.mongodb>
+
<container.image.keycloak>${container.image.keycloak}</container.image.keycloak>
+
<container.image.infinispan>${container.image.infinispan}</container.image.infinispan>
+
<container.image.kafka>${container.image.kafka}</container.image.kafka>
+
<native.image.path>${project.build.directory}/${project.build.finalName}-runner</native.image.path>
</systemPropertyVariables>
+
<classesDirectory>${project.build.outputDirectory}</classesDirectory>
+
<workingDirectory>${project.build.directory}/test-run</workingDirectory>
</configuration>
+ <executions>
+ <execution>
+ <goals>
+ <goal>integration-test</goal>
+ <goal>verify</goal>
+ </goals>
+ </execution>
+ </executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-failsafe-plugin</artifactId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <version>${version.enforcer.plugin}</version>
+ <executions>
+ <execution>
+ <id>enforce-versions</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <requireMavenVersion>
+ <version>${version.maven}</version>
+ </requireMavenVersion>
+ <requireJavaVersion>
+ <version>${maven.compiler.release}</version>
+ </requireJavaVersion>
+ </rules>
+ </configuration>
+ </execution>
+ </executions>
+ <configuration>
+ <skip>true</skip>
+ </configuration>
Review Comment:
We’re not defining the enforcer here; the skip was already present in the
old root POM, and this PR only merged duplicate declarations.
Removing our block doesn’t disable it — it’s inherited from
`kie-parent`/`kogito-build-no-bom-parent`, and I verified the rules still run
and fail.
I tested skipping only the two incompatible rules; the remaining rules work
but expose 4 existing dependency violations that need fixing.
I’ll handle those in a follow-up PR if needed, enable the 3 workable rules,
and clean up the now-dead `enforce-versions` config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
