nrknithin commented on code in PR #2244:
URL:
https://github.com/apache/incubator-kie-examples/pull/2244#discussion_r3895082156
##########
kogito-springboot-examples/pom.xml:
##########
@@ -24,26 +24,124 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
<modelVersion>4.0.0</modelVersion>
+ <!-- The Spring Boot examples inherit from the Kogito Spring Boot BOM so
that the Spring Boot platform version, the
+ spring-boot-maven-plugin version and the Spring Boot-targeted
dependency management are all taken from the
+ single place that defines them on the kie side. No Spring Boot version
is declared in the Maven examples (the Gradle examples keep their own literal
pins in
+ gradle.properties: Gradle cannot inherit from a Maven parent).
+
+ A pom has a single parent, so this aggregator does not inherit from the
examples root
+ (kogito-examples), which is a plain module list. The build
configuration below (test wiring,
+ container properties, packaging manifests, reproducible-build settings,
project metadata) is the
+ examples' shared configuration; kogito-quarkus-examples and
kogito-springboot-examples each carry
+ it and must be kept in sync. -->
<parent>
- <groupId>org.kie.kogito.examples</groupId>
- <artifactId>kogito-examples</artifactId>
+ <groupId>org.kie.kogito</groupId>
+ <artifactId>kogito-spring-boot-bom</artifactId>
<version>999-SNAPSHOT</version>
+ <relativePath/>
</parent>
+ <groupId>org.kie.kogito.examples</groupId>
<artifactId>kogito-springboot-examples</artifactId>
<packaging>pom</packaging>
<name>Kogito Example :: Spring Boot</name>
+ <description>Kogito Example :: Spring Boot</description>
+
+ <url>http://kogito.kie.org/kogito-springboot-examples</url>
+ <inceptionYear>2019</inceptionYear>
+ <organization>
+ <name>The Apache Software Foundation</name>
+ <url>https://apache.org/</url>
+ </organization>
+
+ <licenses>
+ <license>
+ <name>Apache Software License, Version 2.0</name>
+ <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
+ <distribution>repo</distribution>
+ </license>
+ </licenses>
+
+ <scm>
+
<connection>scm:git:https://github.com/apache/incubator-kie-examples.git/kogito-springboot-examples</connection>
+
<developerConnection>scm:git:https://github.com/apache/incubator-kie-examples.git/kogito-springboot-examples</developerConnection>
+
<url>https://github.com/apache/incubator-kie-examples/kogito-springboot-examples</url>
+ </scm>
+
+ <developers>
+ <developer>
+ <name>The Apache KIE Team</name>
+ <email>[email protected]</email>
+ <url>https://kie.apache.org</url>
+ <organization>Apache Software Foundation</organization>
+ <organizationUrl>http://apache.org/</organizationUrl>
+ </developer>
+ </developers>
+
+ <mailingLists>
+ <mailingList>
+ <name>Development List</name>
+ <subscribe>[email protected]</subscribe>
+ <unsubscribe>[email protected]</unsubscribe>
+ <post>[email protected]</post>
+ <archive>https://lists.apache.org/[email protected]</archive>
+ </mailingList>
+ <mailingList>
+ <name>User List</name>
+ <subscribe>[email protected]</subscribe>
+ <unsubscribe>[email protected]</unsubscribe>
+ <post>[email protected]</post>
+
<archive>https://lists.apache.org/[email protected]</archive>
+ </mailingList>
+ <mailingList>
+ <name>Commits List</name>
+ <subscribe>[email protected]</subscribe>
+ <unsubscribe>[email protected]</unsubscribe>
+ <post>[email protected]</post>
+
<archive>https://lists.apache.org/[email protected]</archive>
+ </mailingList>
+ </mailingLists>
<properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
+ <version.org.kie.kogito>999-SNAPSHOT</version.org.kie.kogito>
+
+ <surefire.forkCount>1</surefire.forkCount>
+ <failsafe.include>**/*IT.java</failsafe.include>
+ <failsafe.exclude>**/Native*IT.java</failsafe.exclude>
+ <alphanetworkCompilerEnabled>false</alphanetworkCompilerEnabled>
+ <tests.category></tests.category>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Review Comment:
Leftover from moving the config out of the root pom. Removed the duplicate,
kept the one at line 106.
##########
kogito-quarkus-examples/kogito-travel-agency/pom.xml:
##########
@@ -35,20 +35,9 @@
<module>extended</module>
</modules>
<properties>
- <quarkus-plugin.version>3.27.5.1</quarkus-plugin.version>
- <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
- <quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
- <quarkus.platform.version>3.27.5.1</quarkus.platform.version>
</properties>
<dependencyManagement>
<dependencies>
- <dependency>
- <groupId>${quarkus.platform.group-id}</groupId>
- <artifactId>${quarkus.platform.artifact-id}</artifactId>
- <version>${quarkus.platform.version}</version>
- <type>pom</type>
- <scope>import</scope>
- </dependency>
</dependencies>
</dependencyManagement>
Review Comment:
Right, those are leftovers from dropping the platform BOM import. Removed
the empty blocks — also in onboarding-example/payroll/pom.xml, which had the
same leftover but wasn't flagged.
##########
kogito-quarkus-examples/kogito-travel-agency/pom.xml:
##########
@@ -35,20 +35,9 @@
<module>extended</module>
</modules>
<properties>
- <quarkus-plugin.version>3.27.5.1</quarkus-plugin.version>
- <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
- <quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
- <quarkus.platform.version>3.27.5.1</quarkus.platform.version>
Review Comment:
Same block as above — removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
