ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r373753338
########## File path: benchmark/opperf/utils/op_registry_utils.py ########## @@ -23,8 +23,7 @@ from benchmark.opperf.rules.default_params import DEFAULTS_INPUTS, MX_OP_MODULE # Operators where parameter have special criteria that cannot be cleanly automated. -# Example: sample_multinomial operator has a parameter 'data'. It expects values to sum up to 1. -unique_ops = ("sample_multinomial",) +unique_ops = () Review comment: since this is empty. do we need it any longer? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services