ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement
remaining random sampling ops
URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r373753403
##########
File path: benchmark/opperf/utils/op_registry_utils.py
##########
@@ -223,13 +226,17 @@ def get_all_random_sampling_operators():
-------
{"operator_name": {"has_backward", "nd_op_handle", "params"}}
"""
+ # Additional Random Sampling ops which do not start with "random_" or
"sample_"
+ additional_random_sampling_ops = ['GridGenerator', 'BilinearSampler']
+
# Get all mxnet operators
mx_operators = _get_all_mxnet_operators()
# Filter for Random Sampling operators
random_sampling_mx_operators = {}
for op_name, op_params in mx_operators.items():
- if op_name.startswith(("random_", "sample_")) and op_name not in
unique_ops:
+ if (op_name.startswith(("random_", "sample_")) or \
+ op_name in additional_random_sampling_ops) and op_name not in
unique_ops:
Review comment:
lets get rid of this unique_ops condition since there are no longer
unique_ops remaining!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
