apeforest commented on a change in pull request #17502: [OpPerf] Implement
remaining random sampling ops
URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r374289421
##########
File path: benchmark/opperf/rules/default_params.py
##########
@@ -152,7 +158,13 @@
"dim1": DEFAULT_DIM_1,
"dim2": DEFAULT_DIM_2,
"block_size": DEFAULT_BLOCK_SIZE,
- "args": DEFAULT_ARGS}
+ "args": DEFAULT_ARGS,
+ "grid": DEFAULT_GRID,
+ "data_bilinearsampler": DEFAULT_DATA_BILINEAR,
Review comment:
Seems there are very operator specific. What if these arguments change in
mxnet 2.0 does it break this opperf utility. Is there a way to generalize these
op specific params, like passing them in as general `args` param?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
