ChaiBapchya commented on a change in pull request #17502: [OpPerf] Implement remaining random sampling ops URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r375606358
########## File path: benchmark/opperf/utils/op_registry_utils.py ########## @@ -279,9 +280,9 @@ def get_all_optimizer_operators(): # Filter for Optimizer operators optimizer_mx_operators = {} - for op_name, _ in mx_operators.items(): - if op_name in optimizer_ops and op_name not in unique_ops: - optimizer_mx_operators[op_name] = mx_operators[op_name] + for op_name, op_params in mx_operators.items(): + if op_name in optimizer_ops: Review comment: wait doesn't this give indent error? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services