connorgoggins commented on a change in pull request #17502: [OpPerf] Implement
remaining random sampling ops
URL: https://github.com/apache/incubator-mxnet/pull/17502#discussion_r374393706
##########
File path: benchmark/opperf/rules/default_params.py
##########
@@ -152,7 +158,13 @@
"dim1": DEFAULT_DIM_1,
"dim2": DEFAULT_DIM_2,
"block_size": DEFAULT_BLOCK_SIZE,
- "args": DEFAULT_ARGS}
+ "args": DEFAULT_ARGS,
+ "grid": DEFAULT_GRID,
+ "data_bilinearsampler": DEFAULT_DATA_BILINEAR,
Review comment:
If these arguments change (in terms of data type or arg name) the opperf
utility will fail, as is the case for all of the more general args used in this
file. I could use a general `args` param to pass in the op-specific arguments
and establish a mapping between keywords and values on the fly, which might be
more resilient to potential changes in arg structure (such as arg order or name
changes). @ChaiBapchya any thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
