access2rohit commented on a change in pull request #17677: [Large Tensor] Fix
cumsum op
URL: https://github.com/apache/incubator-mxnet/pull/17677#discussion_r384233536
##########
File path: src/operator/numpy/np_cumsum-inl.h
##########
@@ -125,17 +125,17 @@ void CumsumForward(const nnvm::NodeAttrs& attrs,
struct cumsum_backward {
template<typename IType, typename OType>
- MSHADOW_XINLINE static void Map(int i,
+ MSHADOW_XINLINE static void Map(index_t i,
IType *igrad,
const OType *ograd,
- const int middle,
- const int trailing) {
- int left = i / trailing, right = i % trailing;
- int offset = left * middle * trailing + right;
+ const index_t middle,
+ const index_t trailing) {
+ index_t left = i / trailing, right = i % trailing;
+ index_t offset = left * middle * trailing + right;
const OType *lane_ograd = ograd + offset;
IType *lane_igrad = igrad + offset;
Review comment:
same as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
