connorgoggins commented on issue #17677: [Large Tensor] Fix cumsum op
URL: https://github.com/apache/incubator-mxnet/pull/17677#issuecomment-591604673
 
 
   @sandeep-krishnamurthy thanks for your questions!
   
   1. If you look at performance of the `cumsum` op 
[before](https://gist.github.com/connorgoggins/3fc3c7a40dae8b5cea7f82d9ca4b1a72)
 vs. 
[after](https://gist.github.com/connorgoggins/4538df906c3fbe36f989bb9067b8feb8) 
the changes in this PR, you can see that there is no regression on the time 
required for a forward pass.
   2. My current assignment has been to systematically fix all ops with similar 
issues (i.e. throwing errors when handling large tensor data). As of now, I 
have created PRs with fixes for every problematic op, and once all my remaining 
op fix PRs (3 remaining PRs, including this one) are merged, all similar issues 
will be resolved.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to