apeforest commented on a change in pull request #17677: [Large Tensor] Fix cumsum op URL: https://github.com/apache/incubator-mxnet/pull/17677#discussion_r385286229
########## File path: src/operator/numpy/np_cumsum-inl.h ########## @@ -157,10 +157,10 @@ void CumsumBackwardImpl(const OpContext& ctx, } } Stream<xpu> *s = ctx.get_stream<xpu>(); - MSHADOW_TYPE_SWITCH_WITH_BOOL(igrad.type_flag_, IType, { + MSHADOW_TYPE_SWITCH_WITH_BOOL(igrad.type_flag_, index_t, { Review comment: You don't need a macro if the type is predefined. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services