[GitHub] ThomasDelteil commented on a change in pull request #10955: [MXNET-422] Distributed training tutorial

[GitBox]

ThomasDelteil commented on a change in pull request #10955: [MXNET-422] 
Distributed training tutorial
URL: https://github.com/apache/incubator-mxnet/pull/10955#discussion_r188727936
 
 

 ##########
 File path: docs/tutorials/index.md
 ##########
 @@ -38,6 +38,7 @@ Select API: 
     * [Visual Question 
Answering](http://gluon.mxnet.io/chapter08_computer-vision/visual-question-answer.html)
 <img 
src="https://upload.wikimedia.org/wikipedia/commons/6/6a/External_link_font_awesome.svg";
 alt="External link" height="15px" style="margin: 0px 0px 3px 3px;"/>
 * Practitioner Guides
     * [Multi-GPU 
training](http://gluon.mxnet.io/chapter07_distributed-learning/multiple-gpus-gluon.html)
 <img 
src="https://upload.wikimedia.org/wikipedia/commons/6/6a/External_link_font_awesome.svg";
 alt="External link" height="15px" style="margin: 0px 0px 3px 3px;"/>
+    * [Distributed 
Training](https://github.com/apache/incubator-mxnet/tree/master/example/distributed_training)
 
 Review comment:
   Not a big fan to link to the github repo. I understand the tutorial is not 
runnable but I would prefer if it was hosted in the tutorials/docs/gluon to 
avoid fragmentation. Add the right import statements, and put in 
   ```
   runnable: 
       ```python 
       store = mxnet.kv.create('dist')
       ```
   not meant to be run: 
       ```
        for batch in train_data:
            train_batch(batch, ctx, net, trainer)
       ```
   ```
   That way the code you are using is tested against the CI for correctness.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services