nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc
type for the Scala Package
URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r208099476
##########
File path:
scala-package/core/src/main/scala/org/apache/mxnet/io/NDArrayIter.scala
##########
@@ -42,27 +43,40 @@ import scala.collection.immutable.ListMap
class NDArrayIter(data: IndexedSeq[(String, NDArray)],
label: IndexedSeq[(String, NDArray)],
private val dataBatchSize: Int, shuffle: Boolean,
- lastBatchHandle: String) extends DataIter {
-
+ lastBatchHandle: String,
+ dataDType: DType, labelDType: DType,
+ dataLayout: String, labelLayout: String) extends DataIter {
+
+ // scalastyle:off
+ def this(data: IndexedSeq[NDArray], label: IndexedSeq[NDArray],
Review comment:
you need to create constructors(with original parameters) to maintain
backward compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
