nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r208099693
########## File path: scala-package/core/src/test/scala/org/apache/mxnet/IOSuite.scala ########## @@ -99,7 +101,9 @@ class IOSuite extends FunSuite with BeforeAndAfterAll { "data_shape" -> "(3,28,28)", "batch_size" -> "100", "preprocess_threads" -> "4", - "prefetch_buffer" -> "1" + "prefetch_buffer" -> "1", Review comment: create new tests that take new parameters, so we know that the existing APIs don't break. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services