nswamy commented on a change in pull request #11844: [MXNET-689] add DataDesc type for the Scala Package URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r209074345
########## File path: scala-package/core/src/main/scala/org/apache/mxnet/IO.scala ########## @@ -170,6 +194,10 @@ object DataBatch { private var label: IndexedSeq[NDArray] = null private var index: IndexedSeq[Long] = null private var pad: Int = 0 + private var dataLayout: String = Layout.UNDEFINED Review comment: where are these layout and dtype used? if it is in construction you can declare the parameters in constructor as private ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services