[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator

[GitBox]

apeforest commented on a change in pull request #15811: [MXNET-891] Support 
tuple of scales in upsample operator
URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r317811965
 
 

 ##########
 File path: src/operator/nn/upsampling-inl.h
 ##########
 @@ -84,6 +86,21 @@ struct UpSamplingParam : public 
dmlc::Parameter<UpSamplingParam> {
   }
 };  // struct UpSamplingParam
 
+inline std::vector<int> scaleComp(const UpSamplingParam &param) {
 
 Review comment:
   Looking at the definition of scale, it seems to me it's more logical to 
return a TShape object instead of std::vector<int>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services