apeforest commented on a change in pull request #15811: [MXNET-891] Support
tuple of scales in upsample operator
URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r318198645
##########
File path: src/operator/nn/upsampling.cc
##########
@@ -37,13 +37,16 @@ static bool UpSamplingShape(const nnvm::NodeAttrs& attrs,
CHECK_GE(in_shape->size(), 1U);
const mxnet::TShape &dshape = (*in_shape)[0];
mxnet::TShape oshape = dshape;
+ mxnet::TShape scale_hw = scaleComp(param_);
+ int scale_h = scale_hw[0];
+ int scale_w = scale_hw[1];
if (param_.sample_type == up_enum::kNearest) {
CHECK_EQ(in_shape->size(), static_cast<size_t>(param_.num_args));
oshape[1] = 0;
for (auto& shape : *in_shape) {
CHECK_EQ(shape.ndim(), 4U) << \
"UpSamplingNearest: Input data should be 4D in (batch, channel, y, x)";
- int oh = dshape[2]*param_.scale, ow = dshape[3]*param_.scale;
+ int oh = dshape[2]*scale_h, ow = dshape[3]*scale_w;
Review comment:
add space around *
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
