apeforest commented on a change in pull request #15811: [MXNET-891] Support tuple of scales in upsample operator URL: https://github.com/apache/incubator-mxnet/pull/15811#discussion_r317811212
########## File path: 3rdparty/mshadow/mshadow/extension/spatial_upsampling_nearest.h ########## @@ -24,47 +24,55 @@ struct UpSamplingNearestExp : /*! \brief source oprand */ const SrcExp &src_; /*! \brief up sampling scale */ - index_t scale_; + index_t scale_h_; Review comment: wouldn't it be better to use a mxnet::Shape object, or mxnet::Tuple object to store scale_h_ and scale_w_ instead of two integers? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
