rymanluk commented on a change in pull request #283: Adding Periodic
Advertising Feature
URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246755098
##########
File path: nimble/host/include/host/ble_gap.h
##########
@@ -913,6 +966,28 @@ int ble_gap_ext_adv_stop(uint8_t instance);
int ble_gap_ext_adv_set_data(uint8_t instance, struct os_mbuf *data);
int ble_gap_ext_adv_rsp_set_data(uint8_t instance, struct os_mbuf *data);
int ble_gap_ext_adv_remove(uint8_t instance);
+
+#if MYNEWT_VAL(BLE_PERIODIC_ADV)
+/* Periodic Advertising */
+int ble_gap_per_adv_configure(uint8_t instance, const struct
ble_gap_per_adv_params *params);
Review comment:
i would suggest to use following pattern for the function names:
instead of `ble_gap_per_foo` I would go with `ble_gap_periodic_adv_foo`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
