rymanluk commented on a change in pull request #283: Adding Periodic
Advertising Feature
URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246773258
##########
File path: nimble/host/src/ble_gap.c
##########
@@ -2915,8 +2985,515 @@ ble_gap_ext_adv_remove(uint8_t instance)
memset(&ble_gap_slave[instance], 0, sizeof(struct ble_gap_slave_state));
ble_hs_unlock();
+}
+
+#if MYNEWT_VAL(BLE_PERIODIC_ADV)
+static int
+ble_gap_per_adv_params_tx(uint8_t instance,
+ const struct ble_gap_per_adv_params *params)
+
+{
+ struct hci_per_adv_params hci_adv_params;
+ uint8_t buf[BLE_HCI_LE_SET_PER_ADV_PARAMS_LEN];
+ int rc;
+
+ memset(&hci_adv_params, 0, sizeof(hci_adv_params));
+
+ if (params->include_tx_power) {
+ hci_adv_params.properties |=
BLE_HCI_LE_SET_PER_ADV_PROP_INC_TX_PWR;
+ }
+
+ /* Fill optional fields if application did not specify them. */
+ if (params->itvl_min == 0 && params->itvl_max == 0) {
+ hci_adv_params.min_interval = 30 / 1.25; //30 ms
+ hci_adv_params.max_interval = 60 / 1.25; //150 ms
+
+ } else {
+ hci_adv_params.min_interval = params->itvl_min;
+ hci_adv_params.max_interval = params->itvl_max;
+ }
+
+ rc = ble_hs_hci_cmd_build_le_per_adv_params(instance, &hci_adv_params,
buf,
+ sizeof(buf));
+ if (rc != 0) {
+ return rc;
+ }
+
+ rc = ble_hs_hci_cmd_tx_empty_ack(
+ BLE_HCI_OP(BLE_HCI_OGF_LE,
BLE_HCI_OCF_LE_SET_PER_ADV_PARAMS), buf,
+ sizeof(buf));
+
+ if (rc != 0) {
+ return rc;
+ }
+
+ return 0;
+}
+
+static int
+ble_gap_per_adv_params_validate(
+ const struct ble_gap_per_adv_params *params) {
+ if (!params) {
+ return BLE_HS_EINVAL;
+ }
+
+ // 1- if anonymous return BLE_HS_EINVAL
Review comment:
looks like this function should take instance and do full validation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
