rymanluk commented on a change in pull request #283: Adding Periodic
Advertising Feature
URL: https://github.com/apache/mynewt-nimble/pull/283#discussion_r246784139
##########
File path: nimble/include/nimble/hci_common.h
##########
@@ -552,9 +552,17 @@ extern "C" {
/* --- LE set periodic advertising parameters (OCF 0x003E) */
#define BLE_HCI_LE_SET_PER_ADV_PARAMS_LEN (7)
+#define BLE_HCI_LE_SET_PER_ADV_PROP_INC_TX_PWR (0x0040)
/* --- LE set periodic advertising data (OCF 0x003F) */
#define BLE_HCI_LE_SET_PER_ADV_DATA_LEN BLE_HCI_VARIABLE_LEN
+#define BLE_HCI_MAX_PER_ADV_DATA_LEN (252)
+#define BLE_HCI_SET_PER_ADV_DATA_HDR_LEN (3)
+
+#define BLE_HCI_LE_SET_PER_ADV_DATA_OPER_INT (0)
Review comment:
I think we should use the ones from EXT_ADV:
BLE_HCI_LE_SET_EXT_ADV_DATA_OPER_INT and so on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
