[ 
https://issues.apache.org/jira/browse/MINIFI-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949068#comment-15949068
 ] 

ASF GitHub Bot commented on MINIFI-236:
---------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108924646
  
    --- Diff: libminifi/include/core/ProcessSession.h ---
    @@ -122,6 +128,7 @@ class ProcessSession {
       void penalize(std::shared_ptr<core::FlowFile> &flow);
       void penalize(std::shared_ptr<core::FlowFile> &&flow);
     // Import the existed file into the flow
    +  void importFrom(io::DataStream &stream, std::shared_ptr<core::FlowFile> 
&&flow);
    --- End diff --
    
    better comment?


> Ensure processors are all thread safe
> -------------------------------------
>
>                 Key: MINIFI-236
>                 URL: https://issues.apache.org/jira/browse/MINIFI-236
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: C++
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Critical
>             Fix For: cpp-0.2.0
>
>
> Found that RemoteProcessingGroup was not thread safe. Had to move peer and 
> protocol to be thread local variables to successfully allow more concurrent 
> threads to run onTrigger.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to