[ 
https://issues.apache.org/jira/browse/MINIFI-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949339#comment-15949339
 ] 

ASF GitHub Bot commented on MINIFI-236:
---------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108949062
  
    --- Diff: libminifi/src/core/FlowConfiguration.cpp ---
    @@ -40,6 +40,10 @@ std::shared_ptr<core::Processor> 
FlowConfiguration::createProcessor(
         processor = std::make_shared<
             org::apache::nifi::minifi::processors::LogAttribute>(name, uuid);
       } else if (name
    +      == org::apache::nifi::minifi::processors::ListenHTTP::ProcessorName) 
{
    --- End diff --
    
    minor: can we revert this shuffling?


> Ensure processors are all thread safe
> -------------------------------------
>
>                 Key: MINIFI-236
>                 URL: https://issues.apache.org/jira/browse/MINIFI-236
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: C++
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Critical
>             Fix For: cpp-0.2.0
>
>
> Found that RemoteProcessingGroup was not thread safe. Had to move peer and 
> protocol to be thread local variables to successfully allow more concurrent 
> threads to run onTrigger.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to