[
https://issues.apache.org/jira/browse/MINIFI-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949069#comment-15949069
]
ASF GitHub Bot commented on MINIFI-236:
---------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108924803
--- Diff: libminifi/include/processors/GetFile.h ---
@@ -79,16 +80,27 @@ class GetFile : public core::Processor {
virtual void onTrigger(
core::ProcessContext *context,
core::ProcessSession *session);
+ /**
+ * Function that's executed when the processor is scheduled.
+ * @param context process context.
+ * @param sessionFactory process session factory that is used when
creating
+ * ProcessSession objects.
+ */
+ void onSchedule(
+ core::ProcessContext *context,
+ core::ProcessSessionFactory *sessionFactory);
// Initialize, over write by NiFi GetFile
virtual void initialize(void);
// perform directory listing
- void performListing(std::string dir);
+ void performListing(std::string dir,const GetFileRequest &request);
+
--- End diff --
comment
> Ensure processors are all thread safe
> -------------------------------------
>
> Key: MINIFI-236
> URL: https://issues.apache.org/jira/browse/MINIFI-236
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
> Priority: Critical
> Fix For: cpp-0.2.0
>
>
> Found that RemoteProcessingGroup was not thread safe. Had to move peer and
> protocol to be thread local variables to successfully allow more concurrent
> threads to run onTrigger.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
