[
https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159288#comment-16159288
]
ASF GitHub Bot commented on MINIFI-339:
---------------------------------------
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137881550
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -221,51 +223,28 @@ void
RemoteProcessorGroupPort::refreshRemoteSite2SiteInfo() {
if (!rest_user_name_.empty()) {
std::string loginUrl = this->protocol_ + this->host_ + ":" +
std::to_string(this->port_) + "/nifi-api/access/token";
- token = utils::get_token(loginUrl, this->rest_user_name_,
this->rest_password_, this->securityConfig_);
- logger_->log_debug("Token from NiFi REST Api endpoint %s", token);
+ utils::HTTPClient client(loginUrl, ssl_service);
--- End diff --
+1 for stripping raw curl and adding HTTPClient.
> Begin building controlling API to facilitate control of agents
> --------------------------------------------------------------
>
> Key: MINIFI-339
> URL: https://issues.apache.org/jira/browse/MINIFI-339
> Project: Apache NiFi MiNiFi
> Issue Type: New Feature
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
> Priority: Critical
> Labels: Durability, Reliability, Statistics
>
> Begin building the controlling API in MiNiFi C++. This API will evolve and
> likely have public and private elements. As development progresses we may
> want more capabilities.
> What I want to create as a straw man will be basic control and metrics
> gathering
> -- Start
> -- Stop
> -- Pause
> -- Gather metrics
> ** Throughput of of flow components
> ** Execution time ( run time minus sleep time )
> ** Memory consumption
> -- Drain repositories
> -- Switch repository types.
> Better employ update listener within this controlling API
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
