anchao commented on code in PR #12883:
URL: https://github.com/apache/nuttx/pull/12883#discussion_r1713091580
##########
arch/arm/src/armv7-m/arm_saveusercontext.S:
##########
@@ -52,7 +56,11 @@
.globl up_saveusercontext
.globl up_saveusercontext
+#ifdef __ghs__
+ .type up_saveusercontext, $function
+#else
.type up_saveusercontext, %function
Review Comment:
Why not just use double quotes to solve the common compiler issue?
` .type up_saveusercontext, "function"`
##########
libs/libc/machine/arm/gnu/arch_setjmp.S:
##########
@@ -59,7 +61,12 @@
*
****************************************************************************/
+#ifndef __ghs__
.type setjmp, function
+#else
+ .type setjmp, $function
Review Comment:
ditto
##########
libs/libc/machine/arm/gnu/arch_setjmp.S:
##########
@@ -121,7 +128,11 @@ setjmp:
*
****************************************************************************/
+#ifndef __ghs__
.type longjmp, function
+#else
+ .type longjmp, $function
Review Comment:
ditto
##########
libs/libc/modlib/modlib_globals.S:
##########
@@ -16,7 +16,11 @@
.type SYMBOL(\ep), "object"
.endm
.macro SIZE ep
+# if defined(__ghs__)
+ .size SYMBOL(ep), . - SYMBOL(ep)
+# else
.size SYMBOL(\ep), . - SYMBOL(\ep)
Review Comment:
ditto
##########
libs/libc/machine/arm/gnu/arch_setjmp.S:
##########
@@ -31,7 +31,9 @@
.globl setjmp
.globl longjmp
+#ifndef __ghs__
.syntax unified
Review Comment:
you could define "`.syntax unified`" to empty to avoid change common code
##########
arch/arm/src/common/gnu/fork.S:
##########
@@ -78,7 +77,11 @@
****************************************************************************/
.globl up_fork
+#ifdef __ghs__
+ .type up_fork, $function
+#else
.type up_fork, function
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
