extinguish commented on code in PR #12883:
URL: https://github.com/apache/nuttx/pull/12883#discussion_r1713100225
##########
arch/arm/src/armv7-m/arm_saveusercontext.S:
##########
@@ -52,7 +56,11 @@
.globl up_saveusercontext
.globl up_saveusercontext
+#ifdef __ghs__
+ .type up_saveusercontext, $function
+#else
.type up_saveusercontext, %function
Review Comment:
> Why not just use double quotes to solve the common compiler issue? ` .type
up_saveusercontext, "function"`
I have tried this in local, this cannot fix the build error, and will report
the following error:
CC: sched/sched_waitpid.c [asarm] (error
https://github.com/apache/nuttx/pull/2230) common/gnu/fork.S 80: bad directive
.type up_fork , "function"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
