extinguish commented on code in PR #12883:
URL: https://github.com/apache/nuttx/pull/12883#discussion_r1713101652


##########
arch/arm/src/common/gnu/fork.S:
##########
@@ -78,7 +77,11 @@
  ****************************************************************************/
 
        .globl  up_fork
+#ifdef __ghs__
+       .type   up_fork, $function
+#else
        .type   up_fork, function

Review Comment:
   > ditto
   
   same as the previous review comment, I have tried the solution, but cannot 
work, and report error



##########
libs/libc/machine/arm/gnu/arch_setjmp.S:
##########
@@ -59,7 +61,12 @@
  *
  ****************************************************************************/
 
+#ifndef __ghs__
        .type   setjmp, function
+#else
+       .type   setjmp, $function

Review Comment:
   > ditto
   
   same as the previous review comment, I have tried the solution, but cannot 
work, and report error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to