michallenc commented on code in PR #13127: URL: https://github.com/apache/nuttx/pull/13127#discussion_r1730823158
########## include/nuttx/can/can.h: ########## @@ -246,6 +257,46 @@ * is returned with the errno variable set to indicate the * nature of the error. * Dependencies: None + * + * CANIOC_SET_STATE Review Comment: How will this work? If I pass `CAN_STATE_STOP` via the ioctl then I stop the controller? What will happen with currently queued frames? Will the frame currently being transferred aborted or will the ioctlc call wait for the driver to finish? I generally think it is better to have a separate call to start or stop the controller. And then an ioctl to obtain current controller's state (including error active, passive, etc.). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
