pussuw commented on code in PR #15444: URL: https://github.com/apache/nuttx/pull/15444#discussion_r1909109522
########## arch/arm/src/common/Toolchain.defs: ########## @@ -546,10 +546,14 @@ ifeq ($(CONFIG_PIC),y) # Generate an executable elf, need to ignore undefined symbols LDELFFLAGS += --unresolved-symbols=ignore-in-object-files --emit-relocs else - LDELFFLAGS += -r + ifneq ($(CONFIG_BINFMT_ELF_EXECUTABLE),y) + LDELFFLAGS += -r + endif endif -LDELFFLAGS += -e main -T $(call CONVERT_PATH,$(TOPDIR)$(DELIM)libs$(DELIM)libc$(DELIM)modlib$(DELIM)gnu-elf.ld) +ifneq ($(CONFIG_BINFMT_ELF_EXECUTABLE),y) + LDELFFLAGS += -e main -T $(call CONVERT_PATH,$(TOPDIR)$(DELIM)libs$(DELIM)libc$(DELIM)modlib$(DELIM)gnu-elf.ld) Review Comment: You are right, the Linux toolchain has a generic linker script, so maybe this change is not as bad as I initially thought. I personally have the gnu-elf.ld file in the board folder for my projects because I still think it is board specific (for now). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
