pussuw commented on code in PR #15444: URL: https://github.com/apache/nuttx/pull/15444#discussion_r1909118075
########## arch/arm/src/common/Toolchain.defs: ########## @@ -546,10 +546,14 @@ ifeq ($(CONFIG_PIC),y) # Generate an executable elf, need to ignore undefined symbols LDELFFLAGS += --unresolved-symbols=ignore-in-object-files --emit-relocs else - LDELFFLAGS += -r + ifneq ($(CONFIG_BINFMT_ELF_EXECUTABLE),y) + LDELFFLAGS += -r + endif endif -LDELFFLAGS += -e main -T $(call CONVERT_PATH,$(TOPDIR)$(DELIM)libs$(DELIM)libc$(DELIM)modlib$(DELIM)gnu-elf.ld) +ifneq ($(CONFIG_BINFMT_ELF_EXECUTABLE),y) + LDELFFLAGS += -e main -T $(call CONVERT_PATH,$(TOPDIR)$(DELIM)libs$(DELIM)libc$(DELIM)modlib$(DELIM)gnu-elf.ld) Review Comment: > but why not unify the layout now? Us having a unified virtual address spacing (e.g. user in lowmem, kernel in himem) for now is impossible, as we do not have a good mechanism to move memory mapped devices into the kernel virtual memory area (like fdt and vmap). We have the pieces in place but not a single platform implements this AFAIK ? This is why I for example configure MPFS the other way around; userspace starts from 0xc000_0000 and kernel resides in the lower part. I guess this patch does not break this functionality, so I'm fine with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
