yf13 commented on code in PR #15444: URL: https://github.com/apache/nuttx/pull/15444#discussion_r1909581148
########## arch/arm/src/common/Toolchain.defs: ########## @@ -546,10 +546,14 @@ ifeq ($(CONFIG_PIC),y) # Generate an executable elf, need to ignore undefined symbols LDELFFLAGS += --unresolved-symbols=ignore-in-object-files --emit-relocs else - LDELFFLAGS += -r + ifneq ($(CONFIG_BINFMT_ELF_EXECUTABLE),y) + LDELFFLAGS += -r + endif endif -LDELFFLAGS += -e main -T $(call CONVERT_PATH,$(TOPDIR)$(DELIM)libs$(DELIM)libc$(DELIM)modlib$(DELIM)gnu-elf.ld) +ifneq ($(CONFIG_BINFMT_ELF_EXECUTABLE),y) + LDELFFLAGS += -e main -T $(call CONVERT_PATH,$(TOPDIR)$(DELIM)libs$(DELIM)libc$(DELIM)modlib$(DELIM)gnu-elf.ld) Review Comment: @pussuw the `mkexport.sh` is same as before, so board specific scripts are preferred to the default one. This just tries to improve default one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
