nuttxpr commented on PR #16231: URL: https://github.com/apache/nuttx/pull/16231#issuecomment-2812005286
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) The PR summary is good, clearly explaining the "why" and "how". However, it lacks crucial cross-referencing to a NuttX issue. This is mandatory. The submitter *must* create an issue first and link the PR to it. The Impact section is too vague. While it mentions affected modules, it doesn't detail the *specific* impacts as requested by the template. The template explicitly asks for YES/NO answers for each category with descriptions. The author needs to address each point individually (Impact on user, build, hardware, documentation, security, compatibility) with YES/NO and explanations. For example, even if the impact on the user is minimal, they should state "NO" followed by a brief justification like "Existing user code using workqueues should continue to function as expected with potentially slightly different timing." The Testing section is insufficient. While it mentions the test used (`wqueue_test`), it lacks vital information. The template *requires* logs before *and* after the change. Simply stating "Periodical workqueue can work now" is not enough. Concrete evidence of improvement or correct functionality is necessary through logs. The Build Host details are also missing (OS, compiler version, etc.). Furthermore, testing on only one platform (QEMU/x86_64) is likely insufficient for a core change like this. More architectures and boards should be tested. **Therefore, this PR does *not* fully meet the NuttX requirements.** The author needs to: 1. **Link to a NuttX Issue:** Create a corresponding issue in the NuttX issue tracker and reference it in the PR summary. 2. **Elaborate on Impact:** Provide specific YES/NO answers for each impact category with detailed explanations. 3. **Improve Testing:** Include "before" and "after" logs, specify the build host environment details, and ideally test on more platforms/architectures. By addressing these points, the PR will be much stronger and have a higher chance of being accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
