Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049939836
##########
sched/wqueue/kwork_thread.c:
##########
@@ -160,14 +208,19 @@ static int work_thread(int argc, FAR char *argv[])
* so ourselves, and (2) there will be no changes to the work queue
*/
+ ticks = clock_systime_ticks();
+
+ /* Check if there is expired delayed work */
+
+ work_expiration(ticks, wqueue);
+
/* Remove the ready-to-execute work from the list */
- while ((work = (FAR struct work_s *)dq_remfirst(&wqueue->q)) != NULL)
+ while (!list_is_empty(&wqueue->q))
Review Comment:
Done.
##########
sched/wqueue/wqueue.h:
##########
@@ -159,6 +149,24 @@ static inline_function FAR struct kwork_wqueue_s
*work_qid2wq(int qid)
}
}
+static inline_function
+void work_insert_waitq(FAR struct kwork_wqueue_s *wqueue,
+ struct work_s *work)
+{
+ struct list_node *curr;
+
+ list_for_every(&wqueue->wait_q, curr)
+ {
+ struct work_s *curr_work = list_entry(curr, struct work_s, node);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
