acassis commented on code in PR #16312:
URL: https://github.com/apache/nuttx/pull/16312#discussion_r2083365876
##########
tools/Unix.mk:
##########
@@ -768,6 +768,7 @@ savedefconfig: apps_preconfig
$(Q) rm -f warning.tmp
$(Q) rm -f defconfig.tmp
$(Q) rm -f sortedconfig.tmp
+ $(info "The defconfig was generated successfully at $(PWD)/defconfig
.If you're building out-of-tree configuration, then don't forget to copy it
into your defconfig original location")
Review Comment:
@anchao what is the goal of this cmake autosave? If I understood correctly
when user run "make savedefconfig" it will replace the original defconfig for
current board profile. Although this behavior seems good at first glance, the
reason because Greg didn't implement this way it because normally the developer
will use a base board:nsh profile to modify and create a local defconfig that
he/she will move to a new configs/namedir that will be created. I think the
cmake autosave should require a flag to force this behavior, something like
"make -f savedefconfig". Maybe @patacongo could give more details here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
