anchao commented on code in PR #16312:
URL: https://github.com/apache/nuttx/pull/16312#discussion_r2083495087
##########
tools/Unix.mk:
##########
@@ -768,6 +768,7 @@ savedefconfig: apps_preconfig
$(Q) rm -f warning.tmp
$(Q) rm -f defconfig.tmp
$(Q) rm -f sortedconfig.tmp
+ $(info "The defconfig was generated successfully at $(PWD)/defconfig
.If you're building out-of-tree configuration, then don't forget to copy it
into your defconfig original location")
Review Comment:
> @anchao your point makes sense, but then it should be important to have an
option to not replace the original defconfig, because it will add a more steps
for developers creating new profiles: currently after the "cmake savedefconfig"
they will need: cp boards/xxx/xxx/xxxx/configs/nsh/defconfig /backup/configs/
git checkout boards/xxx/xxx/xxxx/configs/nsh/defconfig mkdir
boards/xxx/xxx/xxxx/configs/newbrdcfg/ cp /backup/configs/defconfig
boards/xxx/xxx/xxxx/configs/newbrdcfg/
>
> Compared with current way using "make savedefconfig": mkdir
boards/xxx/xxx/xxxx/configs/newbrdcfg/ cp defconfig
boards/xxx/xxx/xxxx/configs/newbrdcfg/
Regarding first case, why not back up the old version first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
