pkarashchenko commented on code in PR #17340: URL: https://github.com/apache/nuttx/pull/17340#discussion_r2536711622
########## boards/arm/samv7/common/scripts/flash.ld.template: ########## @@ -34,7 +34,7 @@ # define MCUBOOT_HEADER_SIZE CONFIG_SAMV7_MCUBOOT_HEADER_SIZE # ifdef CONFIG_BOARDCTL_BOOT_IMAGE # define FLASH_OFFSET 0 -# define FLASH_IMG_SIZE CONFIG_SAMV7_OTA_PRIMARY_SLOT_OFFSET +# define FLASH_IMG_SIZE CONFIG_SAMV7_OTA_SLOT_SIZE Review Comment: This change is not correct. The `CONFIG_BOARDCTL_BOOT_IMAGE` is defined when we build MCUBoot loader, so it should start from flash offset `0` and has space till first OTA partition starts (aka `CONFIG_SAMV7_OTA_PRIMARY_SLOT_OFFSET`). If MCUBoot image now becomes too big we need to change value of `CONFIG_SAMV7_OTA_PRIMARY_SLOT_OFFSET` and `CONFIG_SAMV7_OTA_SLOT_SIZE` in corresponding `defconfig` and hope that example application will still work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
