michallenc commented on code in PR #17340: URL: https://github.com/apache/nuttx/pull/17340#discussion_r2536837928
########## boards/arm/samv7/common/scripts/flash.ld.template: ########## @@ -34,7 +34,7 @@ # define MCUBOOT_HEADER_SIZE CONFIG_SAMV7_MCUBOOT_HEADER_SIZE # ifdef CONFIG_BOARDCTL_BOOT_IMAGE # define FLASH_OFFSET 0 -# define FLASH_IMG_SIZE CONFIG_SAMV7_OTA_PRIMARY_SLOT_OFFSET +# define FLASH_IMG_SIZE CONFIG_SAMV7_OTA_SLOT_SIZE Review Comment: Wow, we already reserve 128 kB for the bootloader, that should be more than enough. I think we should tweak `same70-qmtech/mcuboot-loader` (and other SAM boards) `defconfig` file instead and disable functionalities not needed for the bootloader build. We definitely don't need `CONFIG_TESTING_RAMTEST` there, `CONFIG_SAMV7_XDMAC` could also be disabled I think and the same goes for `CONFIG_FS_PROCFS`. We also completely disable `CONFIG_SYSTEM_NSH` for NXBoot bootloader build at Elektroline, I suppose we don't need it for MCUboot either, that should save us a lot of flash space (about 30 kBs). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
