fdcavalcanti commented on code in PR #17340: URL: https://github.com/apache/nuttx/pull/17340#discussion_r2538004002
########## boards/arm/samv7/common/scripts/flash.ld.template: ########## @@ -34,7 +34,7 @@ # define MCUBOOT_HEADER_SIZE CONFIG_SAMV7_MCUBOOT_HEADER_SIZE # ifdef CONFIG_BOARDCTL_BOOT_IMAGE # define FLASH_OFFSET 0 -# define FLASH_IMG_SIZE CONFIG_SAMV7_OTA_PRIMARY_SLOT_OFFSET +# define FLASH_IMG_SIZE CONFIG_SAMV7_OTA_SLOT_SIZE Review Comment: Please correct me if I'm wrong. Since this application loads directly to `mcuboot_loader_main`, can we remove the following from the defconfig? - `CONFIG_SYSTEM_NSH` - `CONFIG_TESTING_RAMTEST` This would build properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
