xiaoxiang781216 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2702071000
########## drivers/timers/arch_timer.c: ########## @@ -36,8 +36,13 @@ * Pre-processor Definitions ****************************************************************************/ +/* If no value is given, we proceed with 0 since a timer is used for accurate + * delays. A runtime DEBUGASSERT catches the case where the timer lower-half + * isn't registered in time. + */ + #ifndef CONFIG_BOARD_LOOPSPERMSEC -# define CONFIG_BOARD_LOOPSPERMSEC 0 +#define CONFIG_BOARD_LOOPSPERMSEC (0) Review Comment: ditto ########## sched/clock/clock_delay.c: ########## @@ -56,6 +56,15 @@ * Pre-processor Definitions ****************************************************************************/ +#warning \ Review Comment: do we need check CONFIG_BOARD_LOOPSPERMSEC is deffined and zero before warning ########## drivers/timers/arch_alarm.c: ########## @@ -36,8 +36,13 @@ * Pre-processor Definitions ****************************************************************************/ +/* If no value is given, we proceed with 0 since a one-shot timer is used for + * accurate delays. A runtime DEBUGASSERT catches the case where the one-shot + * timer lower-half isn't registered in time. + */ + #ifndef CONFIG_BOARD_LOOPSPERMSEC -# define CONFIG_BOARD_LOOPSPERMSEC 0 +#define CONFIG_BOARD_LOOPSPERMSEC (0) Review Comment: why change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
