xiaoxiang781216 commented on code in PR #17011:
URL: https://github.com/apache/nuttx/pull/17011#discussion_r2701182109
##########
arch/Kconfig:
##########
@@ -1331,11 +1331,12 @@ comment "Board Settings"
config BOARD_LOOPSPERMSEC
int "Delay loops per millisecond"
- default 5000
+ default 0 if ALARM_ARCH || TIMER_ARCH
Review Comment:
either always zero or remove the default
##########
sched/clock/delay.c:
##########
Review Comment:
remove weak_function and remove ALL implementation from arch/
##########
sched/clock/delay.c:
##########
Review Comment:
change delay.c to clock_delay.c
##########
sched/clock/delay.c:
##########
@@ -56,6 +56,19 @@
* Pre-processor Definitions
****************************************************************************/
+#if (CONFIG_BOARD_LOOPSPERMSEC == 0) && \
+ !(defined(CONFIG_ALARM_ARCH) || defined(CONFIG_TIMER_ARCH))
Review Comment:
let's skip build dealy if arch_alarm.c or arch_timer.c is built
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
