linguini1 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2702566894
########## boards/arm/stm32wl5/nucleo-wl55jc/configs/fb/defconfig: ########## @@ -15,6 +15,7 @@ CONFIG_ARCH_CHIP="stm32wl5" CONFIG_ARCH_CHIP_STM32WL55JC_CPU1=y CONFIG_ARCH_CHIP_STM32WL5=y CONFIG_BOARD_LATE_INITIALIZE=y +CONFIG_BOARD_LOOPSPERMSEC=0 Review Comment: No, because then it allows users to forget to add a proper value when they add a new config/board. The few places where I added zero to the defconfig is only a workaround for boards where no one owns them up come up with a real value. Otherwise this would break CI ########## boards/arm/stm32wl5/nucleo-wl55jc/configs/fb/defconfig: ########## @@ -15,6 +15,7 @@ CONFIG_ARCH_CHIP="stm32wl5" CONFIG_ARCH_CHIP_STM32WL55JC_CPU1=y CONFIG_ARCH_CHIP_STM32WL5=y CONFIG_BOARD_LATE_INITIALIZE=y +CONFIG_BOARD_LOOPSPERMSEC=0 Review Comment: No, because then it allows users to forget to add a proper value when they add a new config/board. The few places where I added zero to the defconfig is only a workaround for boards where no one owns them up come up with a real value. Otherwise this would break CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
