xiaoxiang781216 commented on code in PR #18745:
URL: https://github.com/apache/nuttx/pull/18745#discussion_r3156139262
##########
arch/sim/src/sim/sim_camera.c:
##########
@@ -386,11 +429,63 @@ static void sim_camera_interrupt(wdparm_t arg)
int sim_camera_initialize(void)
{
- sim_camera_priv_t *priv = &g_sim_camera_priv;
+ int count;
+ int first_error = 0;
- imgsensor_register(&priv->sensor);
- imgdata_register(&priv->data);
+ count = host_video_get_device_count();
+ if (count <= 0)
+ {
+ count = 1;
+ }
- wd_start(&priv->wdog, 0, sim_camera_interrupt, (wdparm_t)priv);
- return 0;
+ g_sim_camera_privs = kmm_zalloc(sizeof(sim_camera_priv_t) * (size_t)count);
Review Comment:
delete cast
##########
arch/sim/src/sim/sim_camera.c:
##########
@@ -348,36 +382,45 @@ static int sim_camera_data_start_capture(struct imgdata_s
*data,
priv->capture_cb = callback;
priv->capture_arg = arg;
- return host_video_start_capture(priv->vdev);
+
+ ret = host_video_start_capture(priv->vdev);
+ if (ret < 0)
+ {
+ return ret;
+ }
+
+ priv->capture_started = true;
+ wd_start(&priv->wdog, SIM_CAMERA_PERIOD, sim_camera_interrupt,
+ (wdparm_t)priv);
+ return 0;
}
static int sim_camera_data_stop_capture(struct imgdata_s *data)
{
- sim_camera_priv_t *priv = (sim_camera_priv_t *)data;
+ sim_camera_priv_t *priv = container_of(data, sim_camera_priv_t, data);
priv->next_buf = NULL;
+ priv->capture_started = false;
+ wd_cancel(&priv->wdog);
return host_video_stop_capture(priv->vdev);
}
static void sim_camera_interrupt(wdparm_t arg)
{
sim_camera_priv_t *priv = (sim_camera_priv_t *)arg;
- struct timespec ts;
Review Comment:
why change? don't add the unnecessary change into pr, which just make your
change review
##########
arch/sim/src/sim/sim_camera.c:
##########
@@ -386,11 +429,63 @@ static void sim_camera_interrupt(wdparm_t arg)
int sim_camera_initialize(void)
{
- sim_camera_priv_t *priv = &g_sim_camera_priv;
+ int count;
+ int first_error = 0;
- imgsensor_register(&priv->sensor);
- imgdata_register(&priv->data);
+ count = host_video_get_device_count();
+ if (count <= 0)
+ {
+ count = 1;
+ }
- wd_start(&priv->wdog, 0, sim_camera_interrupt, (wdparm_t)priv);
- return 0;
+ g_sim_camera_privs = kmm_zalloc(sizeof(sim_camera_priv_t) * (size_t)count);
+ if (g_sim_camera_privs == NULL)
+ {
+ return -ENOMEM;
+ }
+
+ for (int i = 0; i < count; i++)
+ {
+ sim_camera_priv_t *priv = &g_sim_camera_privs[i];
+ FAR struct imgsensor_s *sensor = &priv->sensor;
+ int ret;
+
+ priv->data.ops = &g_sim_camera_data_ops;
+ priv->sensor.ops = &g_sim_camera_ops;
+ priv->sensor.frmsizes_num = 1;
+ priv->sensor.frmsizes = g_frmsizes;
+ priv->sensors[0] = sensor;
Review Comment:
why do you need add sensors field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
