PeterBee97 commented on code in PR #18745:
URL: https://github.com/apache/nuttx/pull/18745#discussion_r3159910725
##########
drivers/video/v4l2_cap.c:
##########
@@ -3775,15 +3831,67 @@ static int capture_unlink(FAR struct inode *inode)
int capture_initialize(FAR const char *devpath)
{
- return capture_register(devpath,
- g_capture_data,
- g_capture_registered_sensor,
- g_capture_registered_sensor_num);
+ size_t index;
+ FAR char *registered_devpath;
+ size_t devpath_len;
+ int ret;
+
+ if (devpath == NULL || g_capture_registered_sensor == NULL ||
+ g_capture_registered_sensor_num == 0)
+ {
+ return -EINVAL;
+ }
+
+ if (get_registered_data_index(devpath, &index))
+ {
+ return -EEXIST;
+ }
+
+ if (!get_available_registered_data_index(&index))
+ {
+ return -EINVAL;
+ }
+
+ devpath_len = strlen(devpath) + 1;
+ registered_devpath = kmm_malloc(devpath_len);
+ if (registered_devpath == NULL)
+ {
+ return -ENOMEM;
+ }
+
+ strlcpy(registered_devpath, devpath, devpath_len);
+
+ ret = capture_register(devpath, g_capture_registered_data[index].data,
+ g_capture_registered_sensor,
+ g_capture_registered_sensor_num);
+ if (ret < 0)
+ {
+ kmm_free(registered_devpath);
+ return ret;
+ }
+
+ g_capture_registered_data[index].devpath = registered_devpath;
Review Comment:
changed to save index for reference instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
