acassis commented on code in PR #3474: URL: https://github.com/apache/nuttx-apps/pull/3474#discussion_r3226129393
########## system/nxpkg/pkg_compat.c: ########## @@ -0,0 +1,64 @@ +/**************************************************************************** + * apps/system/nxpkg/pkg_compat.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <errno.h> +#include <string.h> + +#include "pkg.h" + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +const char *pkg_runtime_arch(void) +{ + return CONFIG_ARCH; +} + +const char *pkg_runtime_compat(void) +{ + return CONFIG_ARCH_BOARD; +} + +int pkg_compat_check(FAR const struct pkg_manifest_s *manifest) +{ + if (manifest == NULL) + { + return -EINVAL; + } + + if (strcmp(manifest->arch, pkg_runtime_arch()) != 0) + { + return -EXDEV; + } + + if (strcmp(manifest->compat, pkg_runtime_compat()) != 0) + { + return -EXDEV; + } Review Comment: If you return different errno here, it could be easier to track the root cause of the issue later ########## system/nxpkg/pkg.h: ########## @@ -0,0 +1,187 @@ +/**************************************************************************** + * apps/system/nxpkg/pkg.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __APPS_SYSTEM_NXPKG_PKG_H +#define __APPS_SYSTEM_NXPKG_PKG_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <limits.h> +#include <stdbool.h> +#include <stddef.h> +#include <stdio.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define PKG_REPO_DIR "/data/repo" +#define PKG_REPO_INDEX "/data/repo/index.json" +#define PKG_REPO_INSTALLED "/data/repo/installed.json" +#define PKG_STORE_DIR "/data/pkgs" +#define PKG_TMP_DIR "/data/tmp" +#define PKG_TMP_PKG_DIR "/data/tmp/pkg" Review Comment: @aviralgarg05 I agree with @cederom some of these files should be moved to /etc/nxpkg and others to /var/ (where /var is a TMPFS mounted partition that will be lost after reboot) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
