acassis commented on code in PR #3474:
URL: https://github.com/apache/nuttx-apps/pull/3474#discussion_r3248664870
##########
system/nxpkg/pkg_metadata.c:
##########
@@ -456,6 +471,12 @@ pkg_metadata_find_latest(FAR const struct pkg_index_s
*index,
continue;
}
+ if (strcmp(candidate->arch, arch) != 0 ||
+ strcmp(candidate->compat, compat) != 0)
Review Comment:
Something we missed in previews review: replace strcmp (and other string
functions) with strncmp (and strnxxx) to avoid buffer overflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
