csanchezdll commented on code in PR #18904: URL: https://github.com/apache/nuttx/pull/18904#discussion_r3271919024
########## drivers/mtd/mx25rxx.c: ########## @@ -127,6 +128,14 @@ #define MX25R6435F_SECTOR_COUNT (2048) #define MX25R6435F_PAGE_SIZE (256) +/* MX25L12873G (128 MB) memory capacity */ Review Comment: > Why is MX25L* type flash implemented in mx25rxx.c file? I think it should go to mx25lx.c. This started before this PR. Original implementation for MX25L25673G was done in mx25rxx.c in https://github.com/apache/nuttx/pull/11149. Author was @jrosberg, so he might know better, but my guess is MX25L25673G is QSPI, so it was added in QSPI-based mx25rxx.c instead on in SPI-based mx25lxx.c. MX25L12873G is the same memory, just smaller, so it needs to go in the same file. Also note the Kconfig to make MX25RXX run in "L" mode is even older, https://github.com/apache/nuttx/pull/6687 > What also bothers me is that MX25L12873G is SPI based, but mx25rxx.c is implemented as QSPI driver. MX25L12873G is QSPI, same as MX25L25673G. IMHO, the mx25rxx.c/mx25lxx.c division should be changed to be SPI/QSPI, or even totally removed and all the modes implemented on a single file. But that is a bigger change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
