michallenc commented on code in PR #18904: URL: https://github.com/apache/nuttx/pull/18904#discussion_r3272049789
########## drivers/mtd/mx25rxx.c: ########## @@ -127,6 +128,14 @@ #define MX25R6435F_SECTOR_COUNT (2048) #define MX25R6435F_PAGE_SIZE (256) +/* MX25L12873G (128 MB) memory capacity */ Review Comment: > MX25L12873G is QSPI, same as MX25L25673G. oh, that makes sense, I thought all L devices are SPI only. > Please note all the other models in the file use "MB" abbreviation in those comments. I would change it in all comments - can be a separate commit to distinguish it from new flash addition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
