acassis commented on code in PR #18904: URL: https://github.com/apache/nuttx/pull/18904#discussion_r3273789504
########## drivers/mtd/mx25rxx.c: ########## @@ -127,6 +128,14 @@ #define MX25R6435F_SECTOR_COUNT (2048) #define MX25R6435F_PAGE_SIZE (256) +/* MX25L12873G (128 MB) memory capacity */ Review Comment: @michallenc technically Mb also is wrong, it doesn't mean 10^20 bit (or 1,048,576 bits), but 1.000.000 bits: <img width="649" height="296" alt="image" src="https://github.com/user-attachments/assets/9c3302b6-048d-49f3-8905-1b03e1645ba2"; /> I think the only "safe way" is referring directly to power of 2 bytes: KiB, MiB, etc, so instead of 128 MB or 128 Mb, we should use 32 MiB -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
