JianyuWang0623 opened a new pull request, #19963: URL: https://github.com/apache/nuttx/pull/19963
## Summary - `examples/lvglterm` switched from plain pipes to a pseudo-terminal in nuttx-apps#3742, and its Kconfig now does `select PSEUDOTERM` instead of requiring it to be set explicitly in board defconfigs. - Meanwhile nuttx#19952 (merged 4 seconds before #3742, so it predates the `select`) had explicitly added `CONFIG_PSEUDOTERM=y` to three board defconfigs to make them build. That line, plus the pre-existing `CONFIG_PIPES=y` left over from the old pipe-based implementation, is now redundant. - This drops both now-redundant options from the four affected lvglterm/lvgl_term defconfigs (`esp32p4-tab5/lvgl_term`, `esp32s3-m5-cardputer/lvglterm`, `linum-stm32h753bi/lvglterm`, `linum-stm32h753bi/lvglterm_kbda`), matching what `tools/refresh.sh`'s savedefconfig normalization produces. - This is what was tripping the tree-cleanliness check in CI (e.g. https://github.com/apache/nuttx-apps/actions/runs/32811506503, job `Linux (risc-v-03)`) for any PR built against a nuttx SHA at/after 19952: `testbuild.sh` runs `refresh.sh`, diffs the result against the committed defconfig, and fails because the removed line reappears as a diff. ## Impact NO. No functional impact: `EXAMPLES_LVGLTERM`'s `select PSEUDOTERM` already guarantees `CONFIG_PSEUDOTERM=y`, and `CONFIG_PIPES` is unused by lvglterm since it moved off pipes. ## Testing Build Host: Linux, GCC toolchains: riscv-none-elf-gcc 14.2.0 (esp32p4-tab5), xtensa-esp32s3-elf-gcc 12.2.0 (esp32s3-m5-cardputer), arm-none-eabi-gcc 10.3.1 (linum-stm32h753bi) Target: esp32p4-tab5:lvgl_term, esp32s3-m5-cardputer:lvglterm, linum-stm32h753bi:lvglterm, linum-stm32h753bi:lvglterm_kbda Ran `tools/refresh.sh --silent <board>:<config>` for each of the four configs to confirm savedefconfig now produces a clean diff (no changes reported after removing the two lines), then built each with `tools/configure.sh <board>:<config>` + `make -j$(nproc)`. All four link successfully, e.g.: ``` [1/1] Normalize esp32p4-tab5:lvgl_term (no diff — refresh.sh reports nothing to change) ... LD: nuttx CP: nuttx.hex MKIMAGE: NuttX binary Generated: nuttx.bin ``` Ran `tools/checkpatch.sh -f <file>` on all four modified defconfigs: `All checks pass.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
