JianyuWang0623 commented on PR #19963: URL: https://github.com/apache/nuttx/pull/19963#issuecomment-5411346481
Closing in favor of the root-cause fix in apache/nuttx-apps#3754, which switches `examples/lvglterm/Kconfig` from `select PSEUDOTERM` to `depends on PSEUDOTERM`. This PR removed `CONFIG_PSEUDOTERM=y` from the board defconfigs on the premise that `select PSEUDOTERM` guarantees it. #3754 removes exactly that `select`, so once it merges the explicit `CONFIG_PSEUDOTERM=y` in these defconfigs is required again — dropping it would make `EXAMPLES_LVGLTERM` unselectable. Fixing the anti-pattern once in the example's Kconfig is the better approach than patching each board. #3754 is already approved by maintainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
